Skip to content

Mangle empty type lists on anonymous contexts. #38160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

augusto2112
Copy link
Contributor

An empty type-list should be mangled as 'y', but this is not being done when mangling anonymous contexts. This PR fixes it.

@augusto2112 augusto2112 requested a review from jckarter June 29, 2021 20:43
@augusto2112
Copy link
Contributor Author

@swift-ci test

@augusto2112
Copy link
Contributor Author

@swift-ci smoke test

@al45tair
Copy link
Contributor

Please can you add a test case to swift/test/Demangle/Inputs/manglings.txt?

@augusto2112 augusto2112 force-pushed the mangle-empty-type-list branch from f9de8b1 to 42dc56a Compare June 30, 2021 14:03
@augusto2112 augusto2112 requested a review from al45tair June 30, 2021 14:03
@augusto2112
Copy link
Contributor Author

@swift-ci smoke test

Copy link
Contributor

@al45tair al45tair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@augusto2112
Copy link
Contributor Author

@swift-ci test

@augusto2112
Copy link
Contributor Author

@swift-ci smoke test

@augusto2112 augusto2112 force-pushed the mangle-empty-type-list branch from 42dc56a to 9f69f55 Compare July 2, 2021 13:19
@augusto2112
Copy link
Contributor Author

@swift-ci smoke test

@augusto2112 augusto2112 merged commit ff7fdc5 into swiftlang:main Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants