Skip to content

Un-XFAIL 2 Concurrency tests on Windows #38169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2021
Merged

Un-XFAIL 2 Concurrency tests on Windows #38169

merged 1 commit into from
Jun 30, 2021

Conversation

meg-gupta
Copy link
Contributor

No description provided.

@meg-gupta meg-gupta requested a review from ktoso June 30, 2021 02:09
@meg-gupta
Copy link
Contributor Author

@swift-ci smoke test

ktoso
ktoso approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@ktoso ktoso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, hopefully things work there by now? It was some issues with async code in general, not specifically those two types.

@meg-gupta
Copy link
Contributor Author

@swift-ci smoke test macOS Platform

@meg-gupta
Copy link
Contributor Author

Now that the lldb test is disabled. Trying testing again... @swift-ci smoke test macOS Platform

@shahmishal shahmishal merged commit 93a0c52 into swiftlang:main Jun 30, 2021
@3405691582 3405691582 mentioned this pull request Jul 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meg-gupta @ktoso @shahmishal