[PrintAsObjC] Hack: Assume all option sets have typedefs. #3851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...because otherwise option sets that get imported as members using NS_SWIFT_NAME are printed with an 'enum' tag, and the definition of NS_OPTIONS only declares the typedef under C++. We should come back and figure out something more principled for this later, but for now this solves an issue with generated headers imported into C++ translation units. rdar://problem/27130343
|
@milseman or @DougGregor, mind reviewing this? @swift-ci Please test OS X platform |
|
Jenkins issue. EDIT: Oh, right, planned maintenance. |
|
@swift-ci Please test OS X platform |
|
Testing something for @shahmishal. @swift-ci Please smoke test OS X platform |
|
@milseman / @DougGregor ping |
|
LGTM |
|
Thanks. Re-smoke-testing just to be sure it still builds cleanly. @swift-ci Please smoke test OS X platform |
|
Does not affect Linux. Force-merging. |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Aug 3, 2016
…3851) ...because otherwise option sets that get imported as members using NS_SWIFT_NAME are printed with an 'enum' tag, and the definition of NS_OPTIONS only declares the typedef under C++. We should come back and figure out something more principled for this later, but for now this solves an issue with generated headers imported into C++ translation units. rdar://problem/27130343 (cherry picked from commit 02d2517)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...because otherwise option sets that get imported as members using NS_SWIFT_NAME are printed with an
enumtag, and the definition of NS_OPTIONS only declares the typedef under C++.We should come back and figure out something more principled for this later, but for now this solves an issue with generated headers imported into C++ translation units.
rdar://problem/27130343
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.