AST: GenericSignatures don't contain type variables #38763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
CodaFi
reviewed
Aug 5, 2021
| return AllocationArena::Permanent; | ||
|
|
||
| if (genericSig.hasTypeVariable()) { | ||
| assert(false && "Unsubstituted type variable leaked into generic signature"); |
There was a problem hiding this comment.
Do we preserve this assert anywhere else?
There was a problem hiding this comment.
Yep, GenericSignature::get() on ASTContext.cpp line 4476. That seems to be the only entry point where we actually create new signatures, so I thought that was the best place to put it.
CodaFi
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.