[Tests] Fix RemoteMirror test to work when DYLD_LIBRARY_PATH is set. #38960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the RemoteMirror test to work around DYLD_LIBRARY_PATH when it's given an absolute path; when it's called from CI, we really want it to load the libswiftRemoteMirror.dylib that we just built, *not* the system one, which is what happens for some of the builders. rdar://82124292
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@swift-ci Please test |
|
@swift-ci Please smoke test |
|
Build failed |
Replaced dirname() as the man page says (alarmingly) that it might write to the input string. Also use asprintf() to build the new value for DYLD_LIBRARY_PATH.
|
@swift-ci Please test |
|
@swift-ci Please smoke test |
mikeash
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the RemoteMirror test to work around
DYLD_LIBRARY_PATHwhen it's given an absolute path; when it's called from CI, we really want it to load thelibswiftRemoteMirror.dylibthat we just built, not the system one, which is what happens for some of the builders.rdar://82124292