[5.5] cherry-pick recent ABI checker changes #39033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing an import statement can be potentially source-breaking. We should prepare for diagnosing such case.
…criptor as byproduct We have implemented a libSwiftDriver-based tool to generate prebuilt module cache for entire SDKs. Anchored on the same infrastructure, we could also generate ABI baselines for entire SDKs.
|
@swift-ci please test |
nkcsgexi
force-pushed
the
api-checker-5.5
branch
from
8bd2a64 to
2de1653
Compare
|
@swift-ci please test |
|
Build failed |
Moving generic constraint from extension to its member or vice versa may change the mangled name of the member without changing the generic signature, thus introducing ABI breakages. This change teaches the ABI checker to diagnose USR (mangled name) changes to cover such cases. rdar://78276290
There is a reference to `std::string` being introduced without the necessary header being included. Add the missing include.
nkcsgexi
force-pushed
the
api-checker-5.5
branch
from
2de1653 to
4b4dee2
Compare
|
@swift-ci please test |
airspeedswift
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These ABI checker enhancements teach the tool to cover more Source/ABI breakages, such as removing import statements and moving members from one extension to another. They also teach
-compile-module-from-interfaceaction to emit ABI baseline as a byproduct, thus our existing prebuilt module generation mechanism could be easily enhanced to generate ABI baselines for entire SDKs.#39010
#38979
#38969
#38943
Related: rdar://78276290