Skip to content

Revert "Fixup Coverage Mapping" #39110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2021
Merged

Revert "Fixup Coverage Mapping" #39110

merged 1 commit into from
Sep 1, 2021

Conversation

etcwilde
Copy link
Member

This reverts commit 40e4206.

llvm::coverage::CoverageFilenamesSectionWriter(FilenameRefs) takes an array of StringRefs, not strings.

rdar://82586177

@etcwilde etcwilde requested a review from CodaFi August 31, 2021 17:53
@etcwilde
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - fe68662

CodaFi
CodaFi approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@CodaFi CodaFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. A revert makes perfect sense.

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - fe68662

@etcwilde etcwilde merged commit 88b7ea3 into swiftlang:rebranch Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodaFi CodaFi CodaFi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etcwilde @swift-ci @CodaFi