Skip to content

[CSFix] Add support for classof for all fixes #39251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Sep 20, 2021

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Sep 11, 2021

  • Require that all sub-classes of ContextualMismatch provide a specific fix kind;
  • Add static bool classof(ConstraintFix *) to all fixes that don't currently have it;
  • Rename fix/diagnostic for checked casts that always succeed;
  • Fix use of ContextualMismatch in a couple of places where IgnoreContextualType is more appropriate.

@xedin xedin requested a review from hborla September 11, 2021 00:21
@xedin
Copy link
Contributor Author

xedin commented Sep 11, 2021

@swift-ci please clean test

Copy link
Member

@hborla hborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! Looks straightforward to me.

@xedin
Copy link
Contributor Author

xedin commented Sep 20, 2021

@swift-ci please smoke test

@xedin xedin merged commit a061a96 into swiftlang:main Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants