Skip to content

[WIP] Remove ParameterTypeFlags from ParenType and TupleType #39318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[WIP] Remove ParameterTypeFlags from ParenType and TupleType #39318

wants to merge 2 commits into from

Conversation

hamishknight
Copy link
Contributor

@hamishknight hamishknight commented Sep 15, 2021 •
edited
Loading

This will almost certainly be split into a bunch of smaller patches, just want to give it an initial run over the source compat suite.

@hamishknight
Copy link
Contributor Author

@slavapestov Another cleanup you might be interested in :)

@slavapestov
Copy link
Contributor

Great stuff!

@slavapestov
Copy link
Contributor

It might be worth getting rid of TypeBase::isMaterializable() now, and replacing it with isLValue() || is<InOutType>() checks (or in cases where only one of those can happen, simplifying it further). "Materializable" is a bit of jargon we can forget about entirely in that case.

@swiftlang swiftlang deleted a comment from swift-ci Sep 15, 2021
@swiftlang swiftlang deleted a comment from swift-ci Sep 15, 2021
@swiftlang swiftlang deleted a comment from swift-ci Sep 16, 2021
@hamishknight hamishknight mentioned this pull request Sep 17, 2021
Merged
@swift-ci

This comment has been minimized.

Sign in to view
@swift-ci

This comment has been minimized.

Sign in to view
@swift-ci

This comment has been minimized.

Sign in to view
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight
Copy link
Contributor Author

@swift-ci please test compiler performance

@swiftlang swiftlang deleted a comment from swift-ci Oct 13, 2021
@swiftlang swiftlang deleted a comment from swift-ci Oct 13, 2021
@swift-ci
Copy link
Contributor

Summary for main full

Regressions found (see below)

Debug-batch

debug-batch brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 98,796,424,149,611 98,807,906,351,117 11,482,201,506 0.01%
LLVM.NumLLVMBytesOutput 2,176,083,716 2,176,089,548 5,832 0.0%

debug-batch detailed

Regressed (2)
name old new delta delta_pct
Sema.HasDynamicCallableAttributeRequest 0 28,546 28,546 100.0% ⛔
Sema.IsCallableNominalTypeRequest 3,804 6,789 2,985 78.47% ⛔
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (256)
name old new delta delta_pct
AST.ImportSetCacheHit 3,173,906 3,174,003 97 0.0%
AST.ImportSetCacheMiss 583,895 583,929 34 0.01%
AST.ImportSetFoldHit 207,613 207,609 -4 -0.0%
AST.ImportSetFoldMiss 376,282 376,320 38 0.01%
AST.ModuleShadowCacheHit 5,440 5,440 0 0.0%
AST.ModuleShadowCacheMiss 2,834 2,834 0 0.0%
AST.ModuleVisibilityCacheHit 135,147 135,147 0 0.0%
AST.ModuleVisibilityCacheMiss 14,501 14,501 0 0.0%
AST.NumASTBytesAllocated 59,454,463,589 59,449,318,802 -5,144,787 -0.01%
AST.NumASTScopeExpansions 8,626,131 8,626,229 98 0.0%
AST.NumASTScopeLookups 9,116,085 9,116,233 148 0.0%
AST.NumDecls 356,544 356,547 3 0.0%
AST.NumDependencies 601,063 601,112 49 0.01%
AST.NumIncrementalDependencies 20,550 20,551 1 0.0%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 353,550 353,582 32 0.01%
AST.NumLocalTypeDecls 365 365 0 0.0%
AST.NumModuleLookupClassMember 8,632 8,632 0 0.0%
AST.NumModuleLookupValue 81,934,984 81,935,902 918 0.0%
AST.NumObjCMethods 58,396 58,396 0 0.0%
AST.NumOperators 1,601 1,601 0 0.0%
AST.NumPrecedenceGroups 243 243 0 0.0%
AST.NumReferencedDynamicNames 220 220 0 0.0%
AST.NumReferencedMemberNames 13,770,715 13,784,578 13,863 0.1%
AST.NumReferencedTopLevelNames 1,326,329 1,326,359 30 0.0%
AST.NumSourceBuffers 517,168 517,186 18 0.0%
AST.NumSourceLines 11,488,459 11,488,509 50 0.0%
AST.NumSourceLinesPerSecond 6,329,951 6,273,439 -56,512 -0.89%
AST.NumTotalClangImportedEntities 2,688,987 2,689,665 678 0.03%
Frontend.MaxMallocUsage 1,033,463,525,736 1,033,665,726,272 202,200,536 0.02%
Frontend.NumInstructionsExecuted 98,796,424,149,611 98,807,906,351,117 11,482,201,506 0.01%
Frontend.NumProcessFailures 48 48 0 0.0%
IRGen.IRGenRequest 31,591 31,592 1 0.0%
IRGen.OptimizedIRRequest 0 0 0 0.0%
IRGen.SymbolObjectCodeRequest 0 0 0 0.0%
IRModule.NumGOTEntries 300,612 300,619 7 0.0%
IRModule.NumIRAliases 233,221 233,223 2 0.0%
IRModule.NumIRBasicBlocks 9,286,584 9,286,658 74 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 4,311,658 4,311,739 81 0.0%
IRModule.NumIRGlobals 4,450,864 4,450,931 67 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 96,289,141 96,289,978 837 0.0%
IRModule.NumIRNamedMetaData 156,632 156,637 5 0.0%
IRModule.NumIRValueSymbols 8,147,634 8,147,778 144 0.0%
LLVM.NumLLVMBytesOutput 2,176,083,716 2,176,089,548 5,832 0.0%
Parse.CodeCompletionSecondPassRequest 0 0 0 0.0%
Parse.NumFunctionsParsed 358,926 358,929 3 0.0%
Parse.NumIterableDeclContextParsed 902,620 902,651 31 0.0%
Parse.ParseAbstractFunctionBodyRequest 624,793 624,795 2 0.0%
Parse.ParseMembersRequest 710,303 710,331 28 0.0%
Parse.ParseSourceFileRequest 508,546 508,561 15 0.0%
SILGen.ASTLoweringRequest 33,019 33,020 1 0.0%
SILGen.ParseSILModuleRequest 0 0 0 0.0%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 3,103,280 3,103,308 28 0.0%
SILModule.NumSILGenGlobalVariables 156,747 156,747 0 0.0%
SILModule.NumSILGenVtables 38,424 38,425 1 0.0%
SILModule.NumSILGenWitnessTables 175,064 175,065 1 0.0%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 3,788,180 3,788,263 83 0.0%
SILModule.NumSILOptGlobalVariables 158,985 158,985 0 0.0%
SILModule.NumSILOptVtables 38,575 38,576 1 0.0%
SILModule.NumSILOptWitnessTables 236,306 236,311 5 0.0%
SILOptimizer.ExecuteSILPipelineRequest 129,266 129,270 4 0.0%
SILOptimizer.LoweredSILRequest 0 0 0 0.0%
Sema.ABIMembersRequest 232,175 232,178 3 0.0%
Sema.AbstractGenericSignatureRequest 58,156 58,158 2 0.0%
Sema.AccessLevelRequest 21,001,843 21,033,874 32,031 0.15%
Sema.ActorIsolationRequest 5,635,578 5,635,935 357 0.01%
Sema.AllMembersRequest 110,481 110,481 0 0.0%
Sema.AnyObjectLookupRequest 321 321 0 0.0%
Sema.ApplyAccessNoteRequest 4,273,589 4,273,765 176 0.0%
Sema.AreAllStoredPropertiesDefaultInitableRequest 41,327 41,327 0 0.0%
Sema.AttachedPropertyWrapperTypeRequest 22,297 22,297 0 0.0%
Sema.AttachedPropertyWrappersRequest 1,978,027 1,978,039 12 0.0%
Sema.AttachedResultBuilderRequest 995,854 995,859 5 0.0%
Sema.BodyInitKindRequest 70,906 70,907 1 0.0%
Sema.CallerSideDefaultArgExprRequest 186,450 186,450 0 0.0%
Sema.CheckInconsistentImplementationOnlyImportsRequest 13,709 13,710 1 0.01%
Sema.CheckRedeclarationRequest 2,173,525 2,173,535 10 0.0%
Sema.ClassAncestryFlagsRequest 158,338 158,344 6 0.0%
Sema.ClosureHasExplicitResultRequest 42,603 42,604 1 0.0%
Sema.CodeCompletionFileRequest 0 0 0 0.0%
Sema.CollectOverriddenDeclsRequest 14,262,444 14,281,838 19,394 0.14%
Sema.CompareDeclSpecializationRequest 747,826 748,252 426 0.06%
Sema.ConditionalRequirementsRequest 898,363 898,536 173 0.02%
Sema.ConformanceHasEffectRequest 0 0 0 0.0%
Sema.CursorInfoRequest 0 0 0 0.0%
Sema.CustomAttrNominalRequest 22,550 22,550 0 0.0%
Sema.CustomAttrTypeRequest 966 966 0 0.0%
Sema.DefaultAndMaxAccessLevelRequest 125,375 125,376 1 0.0%
Sema.DefaultArgumentExprRequest 96,149 96,149 0 0.0%
Sema.DefaultArgumentInitContextRequest 799 799 0 0.0%
Sema.DefaultDefinitionTypeRequest 9,800 9,800 0 0.0%
Sema.DefaultTypeRequest 431,834 431,764 -70 -0.02%
Sema.DerivativeAttrOriginalDeclRequest 16 16 0 0.0%
Sema.DifferentiableAttributeTypeCheckRequest 0 0 0 0.0%
Sema.DirectLookupRequest 59,368,783 59,403,843 35,060 0.06%
Sema.DirectOperatorLookupRequest 1,882,449 1,882,472 23 0.0%
Sema.DirectPrecedenceGroupLookupRequest 801,422 801,429 7 0.0%
Sema.DistributedModuleIsAvailableRequest 0 0 0 0.0%
Sema.DynamicallyReplacedDeclRequest 2,180,506 2,180,529 23 0.0%
Sema.EnumRawTypeRequest 44,192 44,192 0 0.0%
Sema.EnumRawValuesRequest 23,220 23,220 0 0.0%
Sema.ExistentialConformsToSelfRequest 28,463 28,483 20 0.07%
Sema.ExtendedNominalRequest 875,501 875,516 15 0.0%
Sema.ExtendedTypeRequest 155,179 155,181 2 0.0%
Sema.FragileFunctionKindRequest 2,769,198 2,769,231 33 0.0%
Sema.FunctionOperatorRequest 24,302 24,302 0 0.0%
Sema.GenericParamListRequest 6,962,075 6,963,897 1,822 0.03%
Sema.GenericSignatureRequest 3,905,322 3,906,807 1,485 0.04%
Sema.GetDestructorRequest 47,086 47,088 2 0.0%
Sema.GetDistributedRemoteFuncRequest 0 0 0 0.0%
Sema.GetImplicitSendableRequest 411,495 411,747 252 0.06%
Sema.GlobalActorAttributeRequest 6,508,330 6,508,783 453 0.01%
Sema.GlobalActorInstanceRequest 1,183 1,183 0 0.0%
Sema.HasCircularInheritedProtocolsRequest 22,606 22,606 0 0.0%
Sema.HasCircularRawValueRequest 22,930 22,930 0 0.0%
Sema.HasDefaultInitRequest 100,743 100,745 2 0.0%
Sema.HasDynamicMemberLookupAttributeRequest 803,771 803,950 179 0.02%
Sema.HasImplementationOnlyImportsRequest 504,599 504,614 15 0.0%
Sema.HasIsolatedSelfRequest 19,508,432 19,522,068 13,636 0.07%
Sema.HasMemberwiseInitRequest 44,310 44,311 1 0.0%
Sema.HasMissingDesignatedInitializersRequest 31,233 31,233 0 0.0%
Sema.HasUserDefinedDesignatedInitRequest 100,755 100,757 2 0.0%
Sema.InferredGenericSignatureRequest 280,458 280,462 4 0.0%
Sema.InheritedDeclsReferencedRequest 8,887,557 8,913,305 25,748 0.29%
Sema.InheritedProtocolsRequest 991,817 992,533 716 0.07%
Sema.InheritedTypeRequest 515,796 515,848 52 0.01%
Sema.InheritsSuperclassInitializersRequest 44,964 44,965 1 0.0%
Sema.InitKindRequest 181,578 181,581 3 0.0%
Sema.InterfaceTypeRequest 23,424,881 23,442,983 18,102 0.08%
Sema.IsABICompatibleOverrideRequest 317,868 317,871 3 0.0%
Sema.IsAccessorTransparentRequest 636,283 636,287 4 0.0%
Sema.IsActorRequest 2,722,465 2,723,309 844 0.03%
Sema.IsDeclApplicableRequest 0 0 0 0.0%
Sema.IsDeclRefinementOfRequest 47,516 47,516 0 0.0%
Sema.IsDefaultActorRequest 67,660 67,662 2 0.0%
Sema.IsDistributedActorRequest 2,698,796 2,699,657 861 0.03%
Sema.IsDynamicRequest 3,190,520 3,190,555 35 0.0%
Sema.IsFinalRequest 4,417,239 4,419,173 1,934 0.04%
Sema.IsGetterMutatingRequest 764,446 764,415 -31 -0.0%
Sema.IsImplicitlyUnwrappedOptionalRequest 3,988,670 3,987,478 -1,192 -0.03%
Sema.IsObjCRequest 2,998,745 2,998,915 170 0.01%
Sema.IsSetterMutatingRequest 651,209 651,173 -36 -0.01%
Sema.IsStaticRequest 1,714,863 1,714,821 -42 -0.0%
Sema.LazyStoragePropertyRequest 4,114 4,114 0 0.0%
Sema.LookupAllConformancesInContextRequest 2,952,235 2,956,095 3,860 0.13%
Sema.LookupConformanceInModuleRequest 59,213,959 59,256,940 42,981 0.07%
Sema.LookupInModuleRequest 9,429,535 9,430,353 818 0.01%
Sema.LookupInfixOperatorRequest 80,346 80,348 2 0.0%
Sema.LookupPostfixOperatorRequest 94 94 0 0.0%
Sema.LookupPrecedenceGroupRequest 35,350 35,352 2 0.01%
Sema.LookupPrefixOperatorRequest 382 382 0 0.0%
Sema.MangleLocalTypeDeclRequest 69 69 0 0.0%
Sema.ModuleImplicitImportsRequest 13,709 13,710 1 0.01%
Sema.ModuleLibraryLevelRequest 0 0 0 0.0%
Sema.ModuleQualifiedLookupRequest 3,508,216 3,508,904 688 0.02%
Sema.NamedLazyMemberLoadSuccessCount 34,922,469 34,970,300 47,831 0.14%
Sema.NamingPatternRequest 307,579 307,583 4 0.0%
Sema.NeedsNewVTableEntryRequest 1,109,871 1,109,877 6 0.0%
Sema.NumAccessorBodiesSynthesized 479,518 479,519 1 0.0%
Sema.NumAccessorsSynthesized 614,025 614,031 6 0.0%
Sema.NumConformanceAccessPathsRecorded 708,016 708,040 24 0.0%
Sema.NumConformancesDeserialized 14,602,776 14,615,531 12,755 0.09%
Sema.NumConstraintScopes 26,983,540 26,973,600 -9,940 -0.04%
Sema.NumConstraintsConsideredForEdgeContraction 1,698,559 1,698,449 -110 -0.01%
Sema.NumCrossImportsChecked 0 0 0 0.0%
Sema.NumCrossImportsFound 0 0 0 0.0%
Sema.NumCyclicOneWayComponentsCollapsed 0 0 0 0.0%
Sema.NumDeclsDeserialized 106,823,688 106,904,118 80,430 0.08%
Sema.NumDeclsTypechecked 3,062,761 3,062,776 15 0.0%
Sema.NumGenericSignatureBuilders 421,569 421,627 58 0.01%
Sema.NumLazyIterableDeclContexts 13,561,083 13,568,374 7,291 0.05%
Sema.NumLazyRequirementSignatures 1,235,797 1,235,964 167 0.01%
Sema.NumLazyRequirementSignaturesLoaded 877,410 877,909 499 0.06%
Sema.NumLeafScopes 19,409,893 19,406,870 -3,023 -0.02%
Sema.NumRedundantRequirementSteps 1,142,016 1,142,168 152 0.01%
Sema.NumRequirementMachineCompletionSteps 149,560,580 149,871,855 311,275 0.21%
Sema.NumRequirementMachineUnifiedConcreteTerms 110,252 110,363 111 0.1%
Sema.NumRequirementMachines 1,446,442 1,449,004 2,562 0.18%
Sema.NumTypesDeserialized 31,001,934 31,022,496 20,562 0.07%
Sema.NumUnloadedLazyIterableDeclContexts 9,138,097 9,140,789 2,692 0.03%
Sema.OpaqueReadOwnershipRequest 548,299 548,300 1 0.0%
Sema.OpaqueResultTypeRequest 44 44 0 0.0%
Sema.OperatorPrecedenceGroupRequest 1,641 1,641 0 0.0%
Sema.OverriddenDeclsRequest 6,150,910 6,152,762 1,852 0.03%
Sema.ParamSpecifierRequest 2,212,904 2,212,922 18 0.0%
Sema.PatternBindingEntryRequest 801,193 801,200 7 0.0%
Sema.PatternTypeRequest 910,808 910,816 8 0.0%
Sema.PolymorphicEffectKindRequest 154,443 154,445 2 0.0%
Sema.PolymorphicEffectRequirementsRequest 0 0 0 0.0%
Sema.PreCheckResultBuilderRequest 32 32 0 0.0%
Sema.PrimarySourceFilesRequest 13,709 13,710 1 0.01%
Sema.PropertyWrapperAuxiliaryVariablesRequest 622,844 622,849 5 0.0%
Sema.PropertyWrapperBackingPropertyTypeRequest 22,297 22,297 0 0.0%
Sema.PropertyWrapperInitializerInfoRequest 615,940 615,944 4 0.0%
Sema.PropertyWrapperLValuenessRequest 666 666 0 0.0%
Sema.PropertyWrapperMutabilityRequest 758,364 758,333 -31 -0.0%
Sema.PropertyWrapperTypeInfoRequest 251 251 0 0.0%
Sema.ProtocolDependenciesRequest 744,252 745,194 942 0.13%
Sema.ProtocolRequiresClassRequest 53,870 53,906 36 0.07%
Sema.ProvideDefaultImplForRequest 14,262,444 14,281,838 19,394 0.14%
Sema.QualifiedLookupRequest 9,008,935 9,014,048 5,113 0.06%
Sema.RangeInfoRequest 0 0 0 0.0%
Sema.RenamedDeclRequest 18 18 0 0.0%
Sema.RequirementRequest 210,313 210,316 3 0.0%
Sema.RequirementSignatureRequest 955,279 955,831 552 0.06%
Sema.RequiresOpaqueAccessorsRequest 1,902,488 1,902,509 21 0.0%
Sema.RequiresOpaqueModifyCoroutineRequest 541,711 541,719 8 0.0%
Sema.ResolveEffectiveMemberwiseInitRequest 0 0 0 0.0%
Sema.ResolveImplicitMemberRequest 830,129 830,304 175 0.02%
Sema.ResolveProtocolNameRequest 0 0 0 0.0%
Sema.ResolveTypeEraserTypeRequest 0 0 0 0.0%
Sema.ResolveTypeRequest 5,855,057 5,855,108 51 0.0%
Sema.ResultBuilderTypeRequest 492,848 492,853 5 0.0%
Sema.ResultTypeRequest 1,323,785 1,323,793 8 0.0%
Sema.RootAndResultTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.RootTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.SPIGroupsRequest 8,554,885 8,558,538 3,653 0.04%
Sema.ScopedImportLookupRequest 2,348 2,348 0 0.0%
Sema.SelfAccessKindRequest 1,086,081 1,085,995 -86 -0.01%
Sema.SelfBoundsFromWhereClauseRequest 2,581,433 2,583,886 2,453 0.1%
Sema.SetterAccessLevelRequest 261,351 261,303 -48 -0.02%
Sema.SimpleDidSetRequest 3,566,533 3,569,331 2,798 0.08%
Sema.SpecializeAttrTargetDeclRequest 5,704 5,704 0 0.0%
Sema.StorageImplInfoRequest 2,214,267 2,214,209 -58 -0.0%
Sema.StoredPropertiesAndMissingMembersRequest 74,677 74,679 2 0.0%
Sema.StoredPropertiesRequest 477,365 477,383 18 0.0%
Sema.StructuralRequirementsRequest 0 0 0 0.0%
Sema.StructuralTypeRequest 2,744 2,744 0 0.0%
Sema.SuperclassDeclRequest 660,609 662,086 1,477 0.22%
Sema.SuperclassTypeRequest 76,709 76,714 5 0.01%
Sema.SynthesizeAccessorRequest 614,025 614,031 6 0.0%
Sema.SynthesizeDefaultInitRequest 10,102 10,102 0 0.0%
Sema.SynthesizeMainFunctionRequest 229,481 229,483 2 0.0%
Sema.SynthesizeMemberwiseInitRequest 7,856 7,856 0 0.0%
Sema.TangentStoredPropertyRequest 0 0 0 0.0%
Sema.TypeCheckASTNodeAtLocRequest 0 0 0 0.0%
Sema.TypeCheckFunctionBodyRequest 956,778 956,783 5 0.0%
Sema.TypeCheckSourceFileRequest 63,870 63,871 1 0.0%
Sema.TypeDeclsFromWhereClauseRequest 62,170 62,170 0 0.0%
Sema.TypeEraserHasViableInitRequest 0 0 0 0.0%
Sema.TypeRelationCheckRequest 0 0 0 0.0%
Sema.TypeWitnessRequest 14,325 14,325 0 0.0%
Sema.USRGenerationRequest 16,103,650 16,124,081 20,431 0.13%
Sema.UnderlyingTypeDeclsReferencedRequest 480,848 480,971 123 0.03%
Sema.UnderlyingTypeRequest 61,713 61,715 2 0.0%
Sema.UnqualifiedLookupRequest 7,251,942 7,252,081 139 0.0%
Sema.ValidatePrecedenceGroupRequest 234,278 234,282 4 0.0%
Sema.ValueWitnessRequest 103,979 103,979 0 0.0%
TBDGen.APIGenRequest 0 0 0 0.0%
TBDGen.GenerateTBDRequest 0 0 0 0.0%
TBDGen.PublicSymbolsRequest 31,613 31,614 1 0.0%
TBDGen.SymbolSourceMapRequest 0 0 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 96,360,510,559,219 96,348,529,630,685 -11,980,928,534 -0.01%
LLVM.NumLLVMBytesOutput 2,227,829,624 2,227,825,788 -3,836 -0.0%

release detailed

Regressed (2)
name old new delta delta_pct
Sema.HasDynamicCallableAttributeRequest 0 12,334 12,334 100.0% ⛔
Sema.IsCallableNominalTypeRequest 3,158 6,160 3,002 95.06% ⛔
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (256)
name old new delta delta_pct
AST.ImportSetCacheHit 1,611,834 1,611,265 -569 -0.04%
AST.ImportSetCacheMiss 70,710 70,667 -43 -0.06%
AST.ImportSetFoldHit 32,538 32,525 -13 -0.04%
AST.ImportSetFoldMiss 38,172 38,142 -30 -0.08%
AST.ModuleShadowCacheHit 3,590 3,590 0 0.0%
AST.ModuleShadowCacheMiss 1,570 1,570 0 0.0%
AST.ModuleVisibilityCacheHit 53,669 53,647 -22 -0.04%
AST.ModuleVisibilityCacheMiss 4,462 4,456 -6 -0.13%
AST.NumASTBytesAllocated 11,085,523,559 11,074,222,056 -11,301,503 -0.1%
AST.NumASTScopeExpansions 3,588,086 3,586,463 -1,623 -0.05%
AST.NumASTScopeLookups 5,286,328 5,283,839 -2,489 -0.05%
AST.NumDecls 181,810 181,611 -199 -0.11%
AST.NumDependencies 76,856 76,833 -23 -0.03%
AST.NumIncrementalDependencies 0 0 0 0.0%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 31,960 31,941 -19 -0.06%
AST.NumLocalTypeDecls 295 295 0 0.0%
AST.NumModuleLookupClassMember 8,393 8,311 -82 -0.98%
AST.NumModuleLookupValue 34,751,552 34,731,117 -20,435 -0.06%
AST.NumObjCMethods 28,934 28,925 -9 -0.03%
AST.NumOperators 804 804 0 0.0%
AST.NumPrecedenceGroups 125 125 0 0.0%
AST.NumReferencedDynamicNames 0 0 0 0.0%
AST.NumReferencedMemberNames 4,044 4,044 0 0.0%
AST.NumReferencedTopLevelNames 352 352 0 0.0%
AST.NumSourceBuffers 34,530 34,471 -59 -0.17%
AST.NumSourceLines 5,872,207 5,867,241 -4,966 -0.08%
AST.NumSourceLinesPerSecond 372,008 371,524 -484 -0.13%
AST.NumTotalClangImportedEntities 580,952 580,597 -355 -0.06%
Frontend.MaxMallocUsage 327,116,256,232 325,820,888,568 -1,295,367,664 -0.4%
Frontend.NumInstructionsExecuted 96,360,510,559,219 96,348,529,630,685 -11,980,928,534 -0.01%
Frontend.NumProcessFailures 10 10 0 0.0%
IRGen.IRGenRequest 12 12 0 0.0%
IRGen.OptimizedIRRequest 0 0 0 0.0%
IRGen.SymbolObjectCodeRequest 0 0 0 0.0%
IRModule.NumGOTEntries 281,816 281,816 0 0.0%
IRModule.NumIRAliases 186,975 186,975 0 0.0%
IRModule.NumIRBasicBlocks 5,814,270 5,814,270 0 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 3,439,408 3,439,408 0 0.0%
IRModule.NumIRGlobals 3,967,565 3,967,565 0 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 57,001,614 57,001,614 0 0.0%
IRModule.NumIRNamedMetaData 157,010 157,010 0 0.0%
IRModule.NumIRValueSymbols 7,080,639 7,080,639 0 0.0%
LLVM.NumLLVMBytesOutput 2,227,829,624 2,227,825,788 -3,836 -0.0%
Parse.CodeCompletionSecondPassRequest 0 0 0 0.0%
Parse.NumFunctionsParsed 345,814 345,520 -294 -0.09%
Parse.NumIterableDeclContextParsed 116,707 116,566 -141 -0.12%
Parse.ParseAbstractFunctionBodyRequest 315,500 315,444 -56 -0.02%
Parse.ParseMembersRequest 488 488 0 0.0%
Parse.ParseSourceFileRequest 32,798 32,745 -53 -0.16%
SILGen.ASTLoweringRequest 1,444 1,444 0 0.0%
SILGen.ParseSILModuleRequest 0 0 0 0.0%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 1,489,025 1,489,025 0 0.0%
SILModule.NumSILGenGlobalVariables 79,702 79,702 0 0.0%
SILModule.NumSILGenVtables 20,027 20,027 0 0.0%
SILModule.NumSILGenWitnessTables 88,213 88,213 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 1,256,570 1,256,570 0 0.0%
SILModule.NumSILOptGlobalVariables 60,772 60,772 0 0.0%
SILModule.NumSILOptVtables 24,210 24,210 0 0.0%
SILModule.NumSILOptWitnessTables 90,339 90,339 0 0.0%
SILOptimizer.ExecuteSILPipelineRequest 5,768 5,768 0 0.0%
SILOptimizer.LoweredSILRequest 0 0 0 0.0%
Sema.ABIMembersRequest 113,451 113,442 -9 -0.01%
Sema.AbstractGenericSignatureRequest 31,718 31,710 -8 -0.03%
Sema.AccessLevelRequest 1,947,008 1,946,582 -426 -0.02%
Sema.ActorIsolationRequest 2,053,369 2,052,430 -939 -0.05%
Sema.AllMembersRequest 112,048 112,048 0 0.0%
Sema.AnyObjectLookupRequest 323 321 -2 -0.62%
Sema.ApplyAccessNoteRequest 2,014,399 2,013,516 -883 -0.04%
Sema.AreAllStoredPropertiesDefaultInitableRequest 16,551 16,547 -4 -0.02%
Sema.AttachedPropertyWrapperTypeRequest 8,802 8,802 0 0.0%
Sema.AttachedPropertyWrappersRequest 937,956 937,533 -423 -0.05%
Sema.AttachedResultBuilderRequest 549,823 549,601 -222 -0.04%
Sema.BodyInitKindRequest 58,138 58,128 -10 -0.02%
Sema.CallerSideDefaultArgExprRequest 152,581 152,581 0 0.0%
Sema.CheckInconsistentImplementationOnlyImportsRequest 1,454 1,454 0 0.0%
Sema.CheckRedeclarationRequest 1,220,312 1,219,881 -431 -0.04%
Sema.ClassAncestryFlagsRequest 56,887 56,872 -15 -0.03%
Sema.ClosureHasExplicitResultRequest 38,678 38,666 -12 -0.03%
Sema.CodeCompletionFileRequest 0 0 0 0.0%
Sema.CollectOverriddenDeclsRequest 0 0 0 0.0%
Sema.CompareDeclSpecializationRequest 504,422 504,240 -182 -0.04%
Sema.ConditionalRequirementsRequest 225,617 225,529 -88 -0.04%
Sema.ConformanceHasEffectRequest 0 0 0 0.0%
Sema.CursorInfoRequest 0 0 0 0.0%
Sema.CustomAttrNominalRequest 10,547 10,547 0 0.0%
Sema.CustomAttrTypeRequest 327 327 0 0.0%
Sema.DefaultAndMaxAccessLevelRequest 51,799 51,735 -64 -0.12%
Sema.DefaultArgumentExprRequest 48,664 48,642 -22 -0.05%
Sema.DefaultArgumentInitContextRequest 121 121 0 0.0%
Sema.DefaultDefinitionTypeRequest 3,784 3,781 -3 -0.08%
Sema.DefaultTypeRequest 336,682 336,513 -169 -0.05%
Sema.DerivativeAttrOriginalDeclRequest 8 8 0 0.0%
Sema.DifferentiableAttributeTypeCheckRequest 0 0 0 0.0%
Sema.DirectLookupRequest 40,957,838 40,970,089 12,251 0.03%
Sema.DirectOperatorLookupRequest 1,470,548 1,468,512 -2,036 -0.14%
Sema.DirectPrecedenceGroupLookupRequest 695,340 694,255 -1,085 -0.16%
Sema.DistributedModuleIsAvailableRequest 0 0 0 0.0%
Sema.DynamicallyReplacedDeclRequest 991,420 991,227 -193 -0.02%
Sema.EnumRawTypeRequest 11,639 11,637 -2 -0.02%
Sema.EnumRawValuesRequest 12,394 12,392 -2 -0.02%
Sema.ExistentialConformsToSelfRequest 6,625 6,622 -3 -0.05%
Sema.ExtendedNominalRequest 56,354 56,290 -64 -0.11%
Sema.ExtendedTypeRequest 56,276 56,212 -64 -0.11%
Sema.FragileFunctionKindRequest 1,265,106 1,264,749 -357 -0.03%
Sema.FunctionOperatorRequest 11,774 11,774 0 0.0%
Sema.GenericParamListRequest 1,573,788 1,573,172 -616 -0.04%
Sema.GenericSignatureRequest 1,250,003 1,249,767 -236 -0.02%
Sema.GetDestructorRequest 21,506 21,502 -4 -0.02%
Sema.GetDistributedRemoteFuncRequest 0 0 0 0.0%
Sema.GetImplicitSendableRequest 50,738 50,724 -14 -0.03%
Sema.GlobalActorAttributeRequest 2,382,722 2,381,533 -1,189 -0.05%
Sema.GlobalActorInstanceRequest 194 194 0 0.0%
Sema.HasCircularInheritedProtocolsRequest 10,296 10,289 -7 -0.07%
Sema.HasCircularRawValueRequest 11,639 11,637 -2 -0.02%
Sema.HasDefaultInitRequest 36,600 36,589 -11 -0.03%
Sema.HasDynamicMemberLookupAttributeRequest 311,647 311,252 -395 -0.13%
Sema.HasImplementationOnlyImportsRequest 32,691 32,638 -53 -0.16%
Sema.HasIsolatedSelfRequest 4,450,449 4,448,730 -1,719 -0.04%
Sema.HasMemberwiseInitRequest 16,276 16,272 -4 -0.02%
Sema.HasMissingDesignatedInitializersRequest 21,820 21,818 -2 -0.01%
Sema.HasUserDefinedDesignatedInitRequest 36,600 36,589 -11 -0.03%
Sema.InferredGenericSignatureRequest 83,933 83,853 -80 -0.1%
Sema.InheritedDeclsReferencedRequest 1,380,496 1,382,278 1,782 0.13%
Sema.InheritedProtocolsRequest 133,836 133,856 20 0.01%
Sema.InheritedTypeRequest 191,541 191,312 -229 -0.12%
Sema.InheritsSuperclassInitializersRequest 16,693 16,686 -7 -0.04%
Sema.InitKindRequest 71,998 71,976 -22 -0.03%
Sema.InterfaceTypeRequest 4,165,367 4,163,756 -1,611 -0.04%
Sema.IsABICompatibleOverrideRequest 160,661 160,661 0 0.0%
Sema.IsAccessorTransparentRequest 323,122 323,109 -13 -0.0%
Sema.IsActorRequest 381,911 381,712 -199 -0.05%
Sema.IsDeclApplicableRequest 0 0 0 0.0%
Sema.IsDeclRefinementOfRequest 27,573 27,567 -6 -0.02%
Sema.IsDefaultActorRequest 29,152 29,152 0 0.0%
Sema.IsDistributedActorRequest 373,248 373,049 -199 -0.05%
Sema.IsDynamicRequest 1,541,349 1,540,915 -434 -0.03%
Sema.IsFinalRequest 1,224,304 1,223,933 -371 -0.03%
Sema.IsGetterMutatingRequest 410,871 410,712 -159 -0.04%
Sema.IsImplicitlyUnwrappedOptionalRequest 2,355,494 2,354,662 -832 -0.04%
Sema.IsObjCRequest 1,349,433 1,348,987 -446 -0.03%
Sema.IsSetterMutatingRequest 394,327 394,186 -141 -0.04%
Sema.IsStaticRequest 700,146 699,847 -299 -0.04%
Sema.LazyStoragePropertyRequest 863 863 0 0.0%
Sema.LookupAllConformancesInContextRequest 142,377 142,279 -98 -0.07%
Sema.LookupConformanceInModuleRequest 74,407,758 74,376,088 -31,670 -0.04%
Sema.LookupInModuleRequest 2,821,303 2,820,287 -1,016 -0.04%
Sema.LookupInfixOperatorRequest 68,639 68,618 -21 -0.03%
Sema.LookupPostfixOperatorRequest 47 47 0 0.0%
Sema.LookupPrecedenceGroupRequest 31,732 31,715 -17 -0.05%
Sema.LookupPrefixOperatorRequest 178 178 0 0.0%
Sema.MangleLocalTypeDeclRequest 274 274 0 0.0%
Sema.ModuleImplicitImportsRequest 1,454 1,454 0 0.0%
Sema.ModuleLibraryLevelRequest 0 0 0 0.0%
Sema.ModuleQualifiedLookupRequest 533,147 533,042 -105 -0.02%
Sema.NamedLazyMemberLoadSuccessCount 12,197,704 12,205,236 7,532 0.06%
Sema.NamingPatternRequest 84,553 84,529 -24 -0.03%
Sema.NeedsNewVTableEntryRequest 665,983 665,983 0 0.0%
Sema.NumAccessorBodiesSynthesized 246,099 246,052 -47 -0.02%
Sema.NumAccessorsSynthesized 250,243 250,193 -50 -0.02%
Sema.NumConformanceAccessPathsRecorded 786,478 786,474 -4 -0.0%
Sema.NumConformancesDeserialized 3,935,903 3,935,423 -480 -0.01%
Sema.NumConstraintScopes 22,853,372 22,831,526 -21,846 -0.1%
Sema.NumConstraintsConsideredForEdgeContraction 1,755,753 1,751,310 -4,443 -0.25%
Sema.NumCrossImportsChecked 0 0 0 0.0%
Sema.NumCrossImportsFound 0 0 0 0.0%
Sema.NumCyclicOneWayComponentsCollapsed 0 0 0 0.0%
Sema.NumDeclsDeserialized 13,172,113 13,171,563 -550 -0.0%
Sema.NumDeclsTypechecked 1,756,879 1,756,132 -747 -0.04%
Sema.NumGenericSignatureBuilders 119,099 119,001 -98 -0.08%
Sema.NumLazyIterableDeclContexts 1,846,573 1,846,257 -316 -0.02%
Sema.NumLazyRequirementSignatures 148,470 148,415 -55 -0.04%
Sema.NumLazyRequirementSignaturesLoaded 115,694 115,664 -30 -0.03%
Sema.NumLeafScopes 16,343,554 16,334,150 -9,404 -0.06%
Sema.NumRedundantRequirementSteps 342,996 342,587 -409 -0.12%
Sema.NumRequirementMachineCompletionSteps 18,213,036 18,246,595 33,559 0.18%
Sema.NumRequirementMachineUnifiedConcreteTerms 18,604 18,607 3 0.02%
Sema.NumRequirementMachines 183,815 184,007 192 0.1%
Sema.NumTypesDeserialized 5,958,277 5,957,543 -734 -0.01%
Sema.NumUnloadedLazyIterableDeclContexts 1,408,339 1,407,738 -601 -0.04%
Sema.OpaqueReadOwnershipRequest 227,706 227,659 -47 -0.02%
Sema.OpaqueResultTypeRequest 16 16 0 0.0%
Sema.OperatorPrecedenceGroupRequest 714 714 0 0.0%
Sema.OverriddenDeclsRequest 1,533,032 1,532,421 -611 -0.04%
Sema.ParamSpecifierRequest 965,966 965,616 -350 -0.04%
Sema.PatternBindingEntryRequest 377,186 377,046 -140 -0.04%
Sema.PatternTypeRequest 479,823 479,661 -162 -0.03%
Sema.PolymorphicEffectKindRequest 86,304 86,293 -11 -0.01%
Sema.PolymorphicEffectRequirementsRequest 0 0 0 0.0%
Sema.PreCheckResultBuilderRequest 23 23 0 0.0%
Sema.PrimarySourceFilesRequest 1,454 1,454 0 0.0%
Sema.PropertyWrapperAuxiliaryVariablesRequest 388,177 388,037 -140 -0.04%
Sema.PropertyWrapperBackingPropertyTypeRequest 8,802 8,802 0 0.0%
Sema.PropertyWrapperInitializerInfoRequest 394,581 394,441 -140 -0.04%
Sema.PropertyWrapperLValuenessRequest 333 333 0 0.0%
Sema.PropertyWrapperMutabilityRequest 408,644 408,486 -158 -0.04%
Sema.PropertyWrapperTypeInfoRequest 71 71 0 0.0%
Sema.ProtocolDependenciesRequest 108,642 108,739 97 0.09%
Sema.ProtocolRequiresClassRequest 10,874 10,865 -9 -0.08%
Sema.ProvideDefaultImplForRequest 0 0 0 0.0%
Sema.QualifiedLookupRequest 4,758,095 4,759,125 1,030 0.02%
Sema.RangeInfoRequest 0 0 0 0.0%
Sema.RenamedDeclRequest 18 18 0 0.0%
Sema.RequirementRequest 84,209 83,981 -228 -0.27%
Sema.RequirementSignatureRequest 128,446 128,405 -41 -0.03%
Sema.RequiresOpaqueAccessorsRequest 1,437,738 1,437,127 -611 -0.04%
Sema.RequiresOpaqueModifyCoroutineRequest 223,114 223,068 -46 -0.02%
Sema.ResolveEffectiveMemberwiseInitRequest 0 0 0 0.0%
Sema.ResolveImplicitMemberRequest 484,291 484,134 -157 -0.03%
Sema.ResolveProtocolNameRequest 0 0 0 0.0%
Sema.ResolveTypeEraserTypeRequest 0 0 0 0.0%
Sema.ResolveTypeRequest 2,331,252 2,329,344 -1,908 -0.08%
Sema.ResultBuilderTypeRequest 415,175 414,998 -177 -0.04%
Sema.ResultTypeRequest 511,672 511,487 -185 -0.04%
Sema.RootAndResultTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.RootTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.SPIGroupsRequest 2,317,642 2,316,544 -1,098 -0.05%
Sema.ScopedImportLookupRequest 1,282 1,271 -11 -0.86%
Sema.SelfAccessKindRequest 400,873 400,657 -216 -0.05%
Sema.SelfBoundsFromWhereClauseRequest 586,579 586,203 -376 -0.06%
Sema.SetterAccessLevelRequest 161,880 161,834 -46 -0.03%
Sema.SimpleDidSetRequest 410,251 410,177 -74 -0.02%
Sema.SpecializeAttrTargetDeclRequest 2,830 2,830 0 0.0%
Sema.StorageImplInfoRequest 1,572,455 1,571,838 -617 -0.04%
Sema.StoredPropertiesAndMissingMembersRequest 48,407 48,407 0 0.0%
Sema.StoredPropertiesRequest 174,142 174,124 -18 -0.01%
Sema.StructuralRequirementsRequest 0 0 0 0.0%
Sema.StructuralTypeRequest 583 583 0 0.0%
Sema.SuperclassDeclRequest 117,456 117,721 265 0.23%
Sema.SuperclassTypeRequest 26,326 26,317 -9 -0.03%
Sema.SynthesizeAccessorRequest 250,243 250,193 -50 -0.02%
Sema.SynthesizeDefaultInitRequest 3,694 3,693 -1 -0.03%
Sema.SynthesizeMainFunctionRequest 112,361 112,355 -6 -0.01%
Sema.SynthesizeMemberwiseInitRequest 3,157 3,157 0 0.0%
Sema.TangentStoredPropertyRequest 0 0 0 0.0%
Sema.TypeCheckASTNodeAtLocRequest 0 0 0 0.0%
Sema.TypeCheckFunctionBodyRequest 653,313 653,107 -206 -0.03%
Sema.TypeCheckSourceFileRequest 32,774 32,721 -53 -0.16%
Sema.TypeDeclsFromWhereClauseRequest 26,823 26,767 -56 -0.21%
Sema.TypeEraserHasViableInitRequest 0 0 0 0.0%
Sema.TypeRelationCheckRequest 0 0 0 0.0%
Sema.TypeWitnessRequest 4,525 4,522 -3 -0.07%
Sema.USRGenerationRequest 459,370 459,364 -6 -0.0%
Sema.UnderlyingTypeDeclsReferencedRequest 74,619 74,570 -49 -0.07%
Sema.UnderlyingTypeRequest 21,575 21,563 -12 -0.06%
Sema.UnqualifiedLookupRequest 2,759,483 2,757,923 -1,560 -0.06%
Sema.ValidatePrecedenceGroupRequest 223,635 223,580 -55 -0.02%
Sema.ValueWitnessRequest 44,548 44,521 -27 -0.06%
TBDGen.APIGenRequest 0 0 0 0.0%
TBDGen.GenerateTBDRequest 0 0 0 0.0%
TBDGen.PublicSymbolsRequest 1,440 1,440 0 0.0%
TBDGen.SymbolSourceMapRequest 0 0 0 0.0%

@hamishknight
Copy link
Contributor Author

Finally got around to re-visiting this, fresh PR: #60263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla Awaiting requested review from hborla hborla will be requested when the pull request is marked ready for review hborla is a code owner

@xedin xedin Awaiting requested review from xedin xedin will be requested when the pull request is marked ready for review xedin is a code owner

@xymus xymus Awaiting requested review from xymus xymus will be requested when the pull request is marked ready for review xymus is a code owner

@AnthonyLatsis AnthonyLatsis Awaiting requested review from AnthonyLatsis AnthonyLatsis will be requested when the pull request is marked ready for review AnthonyLatsis is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov will be requested when the pull request is marked ready for review slavapestov is a code owner

@jckarter jckarter Awaiting requested review from jckarter jckarter will be requested when the pull request is marked ready for review jckarter is a code owner

@rjmccall rjmccall Awaiting requested review from rjmccall rjmccall will be requested when the pull request is marked ready for review rjmccall is a code owner

@tshortli tshortli Awaiting requested review from tshortli tshortli will be requested when the pull request is marked ready for review tshortli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hamishknight @slavapestov @swift-ci