Re-enable TSan versions of async_let_fibonacci.swift test
#39319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
yln
requested review from
ktoso,
DougGregor,
natecook1000,
kubamracek,
AnnaZaks,
clackary,
danliew-apple and
devincoughlin
yln
force-pushed
the
reenable-tsan-tests
branch
from
424e094 to
5f749ac
Compare
The two TSan versions of the
`test/Concurrency/Runtime/async_let_fibonacci.swift` were disabled for
different reasons:
[1] Swift Concurrency work broke the test and it was never re-enabled.
[2] Regression in atos required test to be disabled. Re-enablement was
blocked on Swift CI upgrading to an Xcode that contains the fixed
version of atos.
While the TSan versions of the test was not running they fell out of
sync with the original test and then started failing for different
(trivial) reasons once re-enabled.
Please help us keep these tests running by:
* Not landing work that makes them fail (and deferring the fix to a
later point), if at all possible. Breaking sanitizers should be a
"blocker".
* Keeping them in sync with the original tests.
Radar-Id: rdar://83162880
[1] rdar://76446550 (Re-enable test: Sanitizers/tsan/async_let_fibonacci.swift)
[2] rdar://80274830 ([Swift CI] Sanitizer report symbolication fails due to regression in atos)
yln
force-pushed
the
reenable-tsan-tests
branch
from
5f749ac to
27b89cc
Compare
|
@swift-ci Please test |
ktoso
approved these changes
Sep 16, 2021
There was a problem hiding this comment.
LGTM, thank you for enabling them.
Not sure how to improve process around not having so many disabled tests; should be something we periodically check for, perhaps something of a policy to figure out by @DougGregor and team?
| @@ -36,6 +27,7 @@ func fib(_ n: Int) -> Int { | |||
|
|
|||
| var racyCounter = 0 | |||
|
|
|||
| @available(SwiftStdlib 5.5, *) | |||
There was a problem hiding this comment.
Suggested change
| @available(SwiftStdlib 5.5, *) |
Could be removed since the -disable-availability-checking was passed.
There was a problem hiding this comment.
These tests mirror what is in test/Concurrency/Runtime/async_let_fibonacci.swift. If this is worth cleaning up, please apply the changes consistently across all versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two TSan versions of the
test/Concurrency/Runtime/async_let_fibonacci.swiftwere disabled fordifferent reasons:
[1] Swift Concurrency work broke the test and it was never re-enabled.
[2] Regression in atos required test to be disabled. Re-enablement was
blocked on Swift CI upgrading to an Xcode that contains the fixed
version of atos.
While the TSan versions of the test was not running they fell out of
sync with the original test and then started failing for different
(trivial) reasons once re-enabled.
Please help us keep these tests running by:
later point), if at all possible. Breaking sanitizers should be a
"blocker".
Radar-Id: rdar://83162880
[1] rdar://76446550 (Re-enable test: Sanitizers/tsan/async_let_fibonacci.swift)
[2] rdar://80274830 ([Swift CI] Sanitizer report symbolication fails due to regression in atos)