Skip to content

benchmarks: Fix an integer overflow problem in the MapReduce benchmarks on 32-bit targets #39396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2021
Merged

benchmarks: Fix an integer overflow problem in the MapReduce benchmarks on 32-bit targets #39396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions benchmark/single-source/MapReduce.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public func run_MapReduce(_ n: Int) {
var c = 0
for _ in 1...n*100 {
numbers = numbers.map { $0 &+ 5 }
c += numbers.reduce(0, &+)
c = c &+ numbers.reduce(0, &+)
}
check(c != 0)
}
Expand All @@ -89,7 +89,7 @@ public func run_MapReduceAnyCollection(_ n: Int) {
var c = 0
for _ in 1...n*100 {
let mapped = numbers.map { $0 &+ 5 }
c += mapped.reduce(0, &+)
c = c &+ mapped.reduce(0, &+)
}
check(c != 0)
}
Expand All @@ -101,7 +101,7 @@ public func run_MapReduceAnyCollectionShort(_ n: Int) {
var c = 0
for _ in 1...n*1_000 {
let mapped = numbers.map { $0 &+ 5 }
c += mapped.reduce(0, &+)
c = c &+ mapped.reduce(0, &+)
}
check(c != 0)
}
Expand All @@ -113,7 +113,7 @@ public func run_MapReduceShort(_ n: Int) {
var c = 0
for _ in 1...n*1_000 {
numbers = numbers.map { $0 &+ 5 }
c += numbers.reduce(0, &+)
c = c &+ numbers.reduce(0, &+)
}
check(c != 0)
}
Expand All @@ -125,7 +125,7 @@ public func run_MapReduceSequence(_ n: Int) {
var c = 0
for _ in 1...n*100 {
let mapped = numbers.map { $0 &+ 5 }
c += mapped.reduce(0, &+)
c = c &+ mapped.reduce(0, &+)
}
check(c != 0)
}
Expand All @@ -137,7 +137,7 @@ public func run_MapReduceLazySequence(_ n: Int) {
var c = 0
for _ in 1...n*100 {
let mapped = numbers.lazy.map { $0 &+ 5 }
c += mapped.reduce(0, &+)
c = c &+ mapped.reduce(0, &+)
}
check(c != 0)
}
Expand All @@ -149,7 +149,7 @@ public func run_MapReduceLazyCollection(_ n: Int) {
var c = 0
for _ in 1...n*100 {
let mapped = numbers.lazy.map { $0 &+ 5 }
c += mapped.reduce(0, &+)
c = c &+ mapped.reduce(0, &+)
}
check(c != 0)
}
Expand All @@ -161,7 +161,7 @@ public func run_MapReduceLazyCollectionShort(_ n: Int) {
var c = 0
for _ in 1...n*10000 {
let mapped = numbers.lazy.map { $0 &+ 5 }
c += mapped.reduce(0, &+)
c = c &+ mapped.reduce(0, &+)
}
check(c != 0)
}
Expand All @@ -172,7 +172,7 @@ public func run_MapReduceString(_ n: Int) {

var c: UInt64 = 0
for _ in 1...n*100 {
c += s.utf8.map { UInt64($0 &+ 5) }.reduce(0, &+)
c = c &+ s.utf8.map { UInt64($0 &+ 5) }.reduce(0, &+)
}
check(c != 0)
}
Expand All @@ -183,7 +183,7 @@ public func run_MapReduceShortString(_ n: Int) {

var c: UInt64 = 0
for _ in 1...n*100 {
c += s.utf8.map { UInt64($0 &+ 5) }.reduce(0, &+)
c = c &+ s.utf8.map { UInt64($0 &+ 5) }.reduce(0, &+)
}
check(c != 0)
}
Expand All @@ -196,7 +196,7 @@ public func run_MapReduceNSDecimalNumber(_ n: Int) {
var c = 0
for _ in 1...n*10 {
let mapped = numbers.map { $0.intValue &+ 5 }
c += mapped.reduce(0, &+)
c = c &+ mapped.reduce(0, &+)
}
check(c != 0)
#endif
Expand All @@ -210,7 +210,7 @@ public func run_MapReduceNSDecimalNumberShort(_ n: Int) {
var c = 0
for _ in 1...n*1_000 {
let mapped = numbers.map { $0.intValue &+ 5 }
c += mapped.reduce(0, &+)
c = c &+ mapped.reduce(0, &+)
}
check(c != 0)
#endif
Expand All @@ -224,7 +224,7 @@ public func run_MapReduceClass(_ n: Int) {
var c = 0
for _ in 1...n*10 {
let mapped = numbers.map { $0.v &+ 5 }
c += mapped.reduce(0, &+)
c = c &+ mapped.reduce(0, &+)
}
check(c != 0)
}
Expand All @@ -236,7 +236,7 @@ public func run_MapReduceClassShort(_ n: Int) {
var c = 0
for _ in 1...n*1_000 {
let mapped = numbers.map { $0.v &+ 5 }
c += mapped.reduce(0, &+)
c = c &+ mapped.reduce(0, &+)
}
check(c != 0)
}