Skip to content

[TypeChecker] Remove remaining isInvalid checks from pattern handling #39417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Sep 23, 2021

  • coercePatternToType - validity is checked before coercions happen;
  • coerceParameterListToType - isInvalid check already rejects invalid decls.

- `coercePatternToType` - validity is checked before coercions happen;
- `coerceParameterListToType` - isInvalid check already rejects invalid decls.
@xedin xedin requested review from slavapestov and CodaFi September 23, 2021 17:29
@xedin
Copy link
Contributor Author

xedin commented Sep 23, 2021

@swift-ci please test

@xedin xedin merged commit b3fcba5 into main Sep 23, 2021
@xedin xedin deleted the remote-invalid-checks-for-pattern-resolution branch September 23, 2021 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants