[SILInliner] Added lexical lifetimes for arguments. #39495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-chandler
force-pushed
the
lexical_lifetimes/inliner
branch
from
42c74bd to
820622a
Compare
|
@swift-ci please test |
Previously, the SILInliner had a few lines of special-case code to handle adding end_borrow instructions to the throw block corresponding to a try_apply instruction. Because there's a mechanism for tracking all places where these end_borrows need to be inserted, just use that mechanism rather than having a special case for the throw block.
When the -enable-experimental-lexical-lifetimes flag is passed, added lexical borrow scopes for every non-trivial argument when inlining a function.
nate-chandler
force-pushed
the
lexical_lifetimes/inliner
branch
from
820622a to
6bcbb04
Compare
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test macos platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the -enable-experimental-lexical-lifetimes flag is passed, added lexical borrow scopes for every non-trivial argument when inlining a function.