Require MainActor isolation on main() function #39503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
|
Build failed |
etcwilde
force-pushed
the
ewilde/mainactor-the-mains
branch
from
41efb85 to
e96b3f0
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
@swift-ci please test Linux platform |
|
@swift-ci please test macOS platform |
This patch forces the main function to be protected behind MainActor isolation. If no actor isolation is specified, the main function will implicitly have MainActor isolation.
Putting the main function under the MainActor appears to have accidentally "fixed" the resilience tests on Windows. I've put the entry to those tests under a separate task to try and avoid accidentally hiding the bug behind the main actor.
etcwilde
force-pushed
the
ewilde/mainactor-the-mains
branch
from
7ee8ea6 to
fa00a32
Compare
|
@swift-ci please test |
etcwilde
changed the title
DougGregor
reviewed
Oct 5, 2021
| ASTContext &ctx = fnDecl->getASTContext(); | ||
|
|
||
| const bool isMainMain = fnDecl->isMainTypeMainMethod(); | ||
| const bool isMain$Main = |
There was a problem hiding this comment.
In theory, I think a C compiler can reject this.
There was a problem hiding this comment.
*pulls out C++ spec*
Yes you are correct. $ is not a valid C++14 identifier-nondigit per 2.10. Will fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch forces the main function to be protected behind MainActor
isolation.
This implements the other part of SE-0323.