Support per host cmake and tsan of runtime via buildscript #3965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than having the cmake generator be decided by 3 different options that can be potentially all set (which makes no sense), this should really just be an option called cmake_generator that would default to ninja and would have choices of xcode, eclipse, etc.
These are computed by build-script and passed directly by build-script-impl into cmake for the relevant target. We can now start to migrate per product cmake options from build-script-impl into build-script.
…_SANITIZERS flag.
|
@swift-ci Please test |
gottesmm
force-pushed
the
support_per_host_cmake_and_tsan_of_runtime_via_buildscript
branch
from
2af9321 to
06a70d3
Compare
|
@swift-ci Please test |
| @@ -1,6 +1,8 @@ | |||
| add_swift_library(swiftAVFoundation ${SWIFT_SDK_OVERLAY_LIBRARY_BUILD_TYPES} IS_SDK_OVERLAY | |||
| AVFoundation.swift | |||
| TARGET_SDKS OSX IOS IOS_SIMULATOR TVOS TVOS_SIMULATOR | |||
| SWIFT_COMPILE_FLAGS "${SWIFT_RUNTIME_SWIFT_COMPILE_FLAGS}" | |||
| LINK_FLAGS "${SWIFT_RUNTIME_SWIFT_LINK_FLAGS}" | |||
There was a problem hiding this comment.
This is a lot of boilerplate for every library, could add_swift_library automatically append these flags if the library is a target library?
There was a problem hiding this comment.
I would want to add an add_swift_target_library.
There was a problem hiding this comment.
But I would like to do it in a subsequent commit.
gottesmm
deleted the
support_per_host_cmake_and_tsan_of_runtime_via_buildscript
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.