Skip to content

[AutoDiff] Compute derivative types using requirements from archetypes. #39728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

rxwei
Copy link
Contributor

@rxwei rxwei commented Oct 13, 2021

When computing a derivative function type, include requirements from archetypes from the original abstraction pattern in the temporary generic signature used for computing the type lowering of tangent vector types.

@rxwei
Copy link
Contributor Author

rxwei commented Oct 13, 2021

@swift-ci please test

@rxwei rxwei force-pushed the autodiff-requirements-from-archetypes branch from 5a0e82f to 8321a14 Compare October 13, 2021 22:32
@rxwei
Copy link
Contributor Author

rxwei commented Oct 13, 2021

@swift-ci please test

@rxwei rxwei requested a review from slavapestov October 13, 2021 22:32
@rxwei rxwei marked this pull request as ready for review October 13, 2021 22:56
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 8321a14bb6e73d885808357dd0e7aeda23ed0f3c

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 8321a14bb6e73d885808357dd0e7aeda23ed0f3c

@rxwei rxwei force-pushed the autodiff-requirements-from-archetypes branch 3 times, most recently from 92404e3 to 91273d3 Compare October 14, 2021 04:22
Resolves rdar://84213107 and partially resolves rdar://82549134.
@rxwei rxwei force-pushed the autodiff-requirements-from-archetypes branch from 91273d3 to 90ec31a Compare October 14, 2021 04:24
@rxwei
Copy link
Contributor Author

rxwei commented Oct 14, 2021

@swift-ci please test

@rxwei rxwei merged commit 92ff0c1 into swiftlang:main Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants