Skip to content

Add Builtin.ifdef_<FLAGNAME> as a facility to peek at -D flag that client code is building with #39797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

kubamracek
Copy link
Contributor

No description provided.

@kubamracek kubamracek requested a review from eeckstein October 17, 2021 16:12
@kubamracek
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!
Just a few comments.
And: please add a test.

@kubamracek kubamracek force-pushed the ifdef-builtin branch 3 times, most recently from 996062c to 3ae4a33 Compare October 19, 2021 23:49
@kubamracek kubamracek requested a review from eeckstein October 19, 2021 23:49
@kubamracek
Copy link
Contributor Author

@eeckstein comments should be addressed now!

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 3ae4a33d64e2cfee8adaba006d93525d1b4949c9

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 52483a1389d26f06b495779947583387457917e2

@kubamracek
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kubamracek kubamracek merged commit b413a0f into swiftlang:main Oct 21, 2021
@kubamracek kubamracek deleted the ifdef-builtin branch October 21, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants