[ConstraintSystem] Don't increase the score for unapplied function references if the expression is an argument to #selector.
#39831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test source compatibility |
xedin
reviewed
Oct 20, 2021
…ferences if the expression is an argument to `#selector`. For `#selector` arguments, functions and properties are syntactically distinct with the getter/setter label, so the solver should not unconditionally prefer properties to unapplied functions. A better fix for this is to port over the `#selector` diagnostics from CSApply, and not attempt invalid disjunction choices based on the selector kind on the valid code path.
hborla
force-pushed
the
invalid-selector-property
branch
from
00e5950 to
beaaee7
Compare
overload set for an argument to a method `#selector`.
|
@swift-ci please test source compatibility |
|
@swift-ci please smoke test |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
#selectorarguments, functions and properties are syntactically distinct with the getter/setter label, so the solver should not unconditionally prefer properties to unapplied functions.Note that a better fix for this is to port over the
#selectordiagnostics from CSApply to constraint fixes, and not attempt invalid disjunction choices based on the selector kind on the valid code path.Resolves: rdar://83779014