Update CHECK to make sure prologue_end's are only on non-zero line number locs and also accounts for multiple digits for column number and file number #39843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly and fixed bug with regex checking for multiple digit column numbers in .loc CHECK
|
@swift-ci please test |
adrian-prantl
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug when building watchOSarm64_32 where the CHECK line was only checking for single digit column numbers and file numbers but the column number was a double digit value.
Also, the line number regex needs to be checking for non-zero line numbers, as we cannot have a prologue_end on a non-zero line number after commit: swiftlang/llvm-project@1813652