Skip to content

[CS] Simplify getAlternativeLiteralTypes #40015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

hamishknight
Copy link
Contributor

Caching the result here feels a little overkill as it's only useful for one protocol, and the TypeChecker::getDefaultType computation is cached by the request evaluator.

Caching the result here feels a little overkill as
it's only useful for one protocol, and the
`TypeChecker::getDefaultType` computation is
cached by the request evaluator.
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight requested a review from xedin November 2, 2021 14:06
@swiftlang swiftlang deleted a comment from swift-ci Nov 2, 2021
@swiftlang swiftlang deleted a comment from swift-ci Nov 2, 2021
@swiftlang swiftlang deleted a comment from swift-ci Nov 2, 2021
@hamishknight hamishknight merged commit ebe93b8 into swiftlang:main Nov 2, 2021
@hamishknight hamishknight deleted the caching-out branch November 2, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants