Skip to content

[LibSyntax] Add leading and trailing spacing for SpacedBinaryOperator #40030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Nov 3, 2021

Swift Syntax PR: swiftlang/swift-syntax#333

@ahoppen
Copy link
Member

ahoppen commented Nov 5, 2021

swiftlang/swift-syntax#333

@swift-ci Please smoke test

@ahoppen ahoppen self-assigned this Nov 5, 2021
@kimdv kimdv force-pushed the kimdv/add-spaing-for-speced-operator branch from e3d0793 to 4679f6e Compare November 6, 2021 08:47
@kimdv kimdv force-pushed the kimdv/add-spaing-for-speced-operator branch from 4679f6e to 5e0c6b6 Compare November 8, 2021 07:26
@ahoppen
Copy link
Member

ahoppen commented Nov 9, 2021

swiftlang/swift-syntax#333

@swift-ci Please smoke test

@kimdv
Copy link
Contributor Author

kimdv commented Nov 9, 2021

@ahoppen I don't need to rebase here with latest from main?

@ahoppen
Copy link
Member

ahoppen commented Nov 9, 2021

I just triggered CI out of habit.

You don’t need to rebase this PR because nothing has changed Token.py recently but I think swiftlang/swift-syntax#333 needs to be rebased.

@ahoppen
Copy link
Member

ahoppen commented Nov 9, 2021

Edit: I think swiftlang/swift-syntax#333 also shouldn’t need a rebase because it’s touching different files than swiftlang/swift-syntax#332. But rebasing never hurts.

@ahoppen
Copy link
Member

ahoppen commented Nov 9, 2021

swiftlang/swift-syntax#333

@swift-ci Please smoke test

@ahoppen ahoppen merged commit ef10aca into swiftlang:main Nov 9, 2021
@kimdv kimdv deleted the kimdv/add-spaing-for-speced-operator branch November 9, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants