Skip to content

IRGen: Default to weak hidden instead of internal linkage for objc metadata #40342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aschwaighofer
Copy link
Contributor

This extends #39944 to apply to more objc metadata.

rdar://85037490

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 49fb8900c8b9f9a4d6344250f5df45c069cadd90

@aschwaighofer aschwaighofer force-pushed the make_objc_metadata_weak_hidden branch from 49fb890 to 0c8a7e0 Compare December 2, 2021 18:15
@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Dec 2, 2021

Build failed
Swift Test Linux Platform
Git Sha - 0c8a7e068da05af63bce3602911d635c2069589e

@aschwaighofer
Copy link
Contributor Author

@swift-ci test linux

@swift-ci
Copy link
Contributor

swift-ci commented Dec 2, 2021

Build failed
Swift Test OS X Platform
Git Sha - 0c8a7e068da05af63bce3602911d635c2069589e

…c metadata

This extends swiftlang#39944 to apply to more objc metadata.

rdar://85037490
@aschwaighofer aschwaighofer force-pushed the make_objc_metadata_weak_hidden branch from 0c8a7e0 to f8d009e Compare December 2, 2021 20:57
@aschwaighofer
Copy link
Contributor Author

@swift-ci test

@aschwaighofer aschwaighofer merged commit 4323d2f into swiftlang:main Dec 6, 2021
aschwaighofer added a commit to aschwaighofer/swift that referenced this pull request Dec 9, 2021
…jc_metadata_weak_hidden"

This reverts commit 4323d2f, reversing
changes made to 451b902.

This caused linking errors on the swift source compat suite in the
Sourcery project.

rdar://86256970
aschwaighofer added a commit that referenced this pull request Dec 9, 2021
Revert "Merge pull request #40342 from aschwaighofer/make_objc_metadata_weak_hidden"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants