[SymbolGraph] consider underscored symbols as private if they're internal
#41156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nternal` rdar://86294802
|
@swift-ci Please smoke test |
|
@swift-ci Please build toolchain macOS platform |
franklinsch
approved these changes
Feb 2, 2022
|
@swift-ci Please build toolchain macOS platform |
|
macOS Toolchain Install command |
This was referenced Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://86294802
When generating a symbol graph, symbols that are prefixed with an underscore are always treated as
internal, regardless of what their original access level is. However, there are more nuanced semantics for underscored symbols that are alreadyinternalor lower - these should be treated asprivatefor the purposes of theminimum-access-leveloption. This PR updates the filtering logic to not emitinternalunderscored symbols unless you specifically request aprivate-level symbol graph.