[SR-15703] Fix missing hop in error path of foreign async throws call #41571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the clean-up is not unwind only, we can rely on the clean-ups to be emitted on both result and throw paths. This does slightly change when the hop_to_executor is emitted, in those paths, but that shouldn't matter. refactors solution for rdar://78982371
resolves rdar://89479707
|
@swift-ci please test and merge |
kavon
added a commit
to kavon/swift
that referenced
this pull request
Apr 25, 2022
This reverts commit 01d470c. Just to be safe, I'm reverting this part of swiftlang#41571 as well, until it can be reimplemented in light of issues where a hop can appear between a get_continuation and an await_continuation resolves rdar://91502776
kavon
added a commit
to kavon/swift
that referenced
this pull request
Apr 25, 2022
This reverts commit 01d470c. Just to be safe, I'm reverting this part of swiftlang#41571 as well, until it can be reimplemented in light of issues where a hop can appear between a get_continuation and an await_continuation resolves rdar://91502776
kavon
added a commit
to kavon/swift
that referenced
this pull request
Apr 25, 2022
This reverts commit 01d470c. Just to be safe, I'm reverting this part of swiftlang#41571 as well, until it can be reimplemented in light of issues where a hop can appear between a get_continuation and an await_continuation resolves rdar://91502776
This was referenced Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error path of the emitted
try_applyhad no hop injected, when it is especially needed if there is acatchin the isolated function.This resolves SR-15703 / rdar://89479707