[ConstraintSystem] Support solving expression patterns via injecting call to ~= operator
#41589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…call to `~=` operator Augment the constraint solver to fallback to implicit `~=` application when member couldn't be found for `EnumElement` patterns because `case` statement should be able to match enum member directly, as well as through an implicit `~=` operator application.
xedin
force-pushed
the
handle-expr-patterns-in-the-solver
branch
from
42ceb18 to
59154d6
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS platform |
hborla
approved these changes
Mar 2, 2022
|
@swift-ci please smoke test macOS platform |
|
Going to re-run macOS before merging just in case anything changed... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Augment the constraint solver to fallback to implicit
~=applicationwhen member couldn't be found for
EnumElementpatterns becausecasestatement should be able to match enum member directly, as wellas through an implicit
~=operator application.