Skip to content

[test] fix test of withMemoryRebound #41596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

glessard
Copy link
Contributor

@glessard glessard commented Mar 1, 2022

Further resolves SR-15912.

- The test did not properly test the intent of the change from 82fa4b0
@glessard
Copy link
Contributor Author

glessard commented Mar 1, 2022

@swift-ci please smoke test

Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@glessard
Copy link
Contributor Author

glessard commented Mar 1, 2022

@swift-ci please smoke test macOS platform

@glessard
Copy link
Contributor Author

glessard commented Mar 1, 2022

The test changed here succeeded. The failure happens in an lldb test later on.

@glessard
Copy link
Contributor Author

glessard commented Mar 1, 2022

@swift-ci please smoke test macOS platform

@glessard glessard merged commit ed1c459 into swiftlang:main Mar 1, 2022
@glessard glessard deleted the se-withMemoryRebound branch March 1, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants