RequirementMachine: Fix terrible bug in minimization of protocol inheritance #41851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
1 similar comment
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test MacOS |
| llvm::MapVector<unsigned, std::vector<SmallVector<unsigned, 2>>> ConformancePaths; | ||
|
|
||
| // The set of conformance rules which are protocol refinements, that is rules of | ||
| // the form [P].[Q] => [P]. | ||
| // The set of conformance rules (from all minimization dmains) which are protocol |
There was a problem hiding this comment.
Suggested change
| // The set of conformance rules (from all minimization dmains) which are protocol | |
| // The set of conformance rules (from all minimization domains) which are protocol |
… rules from all minimization domains
…e refinement Without this, we only considered a protocol refinement rule redundant if it was derived by directly-stated protocol refinements. But this broke when completion introduced a 'transitive' refinement [P].[R] => [P] from two directly-stated refinements [P].[Q] => [P] and [Q].[R] => [Q]. Fixes rdar://problem/90402503.
slavapestov
force-pushed
the
rqm-fix-protocol-refinement-bug
branch
from
ad55e8c to
30da30e
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://problem/90402503.