[CodeCompletion] Don't distinguish convertible and identical type relation #42211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
ahoppen
force-pushed
the
pr/dont-distinguish-identical-convertible-type-relation
branch
from
3a07c07 to
b782853
Compare
|
@swift-ci Please smoke test |
ahoppen
changed the title
rintaro
approved these changes
Apr 12, 2022
…tion I think that preferring identical over convertible makes sense in e.g. C++ where we have implicit user-defined type conversions but since we don’t have them in Swift, I think the distinction doesn’t make too much sense, because if we have a `func foo(x: Int?)`, want don’t really want to prioritize variables of type `Int?` over `Int` Similarly if we have `func foo(x: View)`, we don’t want to prioritize a variable of type `View` over e.g. `Text`. rdar://91349364
ahoppen
force-pushed
the
pr/dont-distinguish-identical-convertible-type-relation
branch
from
b782853 to
5d01a09
Compare
|
@swift-ci Please smoke test |
ahoppen
deleted the
pr/dont-distinguish-identical-convertible-type-relation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that preferring identical over convertible makes sense in e.g. C++ where we have implicit user-defined type conversions but since we don’t have them in Swift, I think the distinction doesn’t make too much sense, because if we have a
func foo(x: Int?), want don’t really want to prioritize variables of typeInt?overIntSimilarly if we havefunc foo(x: View), we don’t want to prioritize a variable of typeViewover e.g.Text.rdar://91349364