[Concurrency] Support duration-based sleep in cooperative executor #42610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
preset=buildbot_incremental_linux_crosscompile_wasm |
…perative executor" This reverts commit d44975b.
kateinoigakukun
force-pushed
the
katei/coop-deadline-job
branch
from
e95d455 to
8c69fda
Compare
|
@swift-ci please smoke test |
|
@phausler can you have a look here? |
phausler
approved these changes
May 13, 2022
|
|
||
| uint64_t delta = (sec - nowSec) * NSEC_PER_SEC + nsec - nowNsec; | ||
|
|
||
| auto deadline = std::chrono::steady_clock::now() |
There was a problem hiding this comment.
So I guess this implementation just ignores the clock parameter then, since this does not have a suspending style clock (std::chrono only has continuous)
I guess that makes sense w/ a single threaded runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repair the test failure of
Concurrency/Runtime/clock.swifton CI with the cooperative executor enabled. See here for the failure logThe failure is just due to missing implementation, so this patch adds the support of the missing duration-based sleep for the cooperative executor.