[3.0] [Type checker] Don't overflow array bounds with #fileLiteral *ahem*. #4921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rdar://problem/26586984. (cherry picked from commit e5b9ad7)
|
@swift-ci please test |
|
@rudkx please review |
rudkx
approved these changes
Sep 22, 2016
| @@ -22,3 +22,5 @@ struct Path: _ExpressibleByFileReferenceLiteral { | |||
|
|
|||
| let p1: Path = #fileLiteral(resourceName: "what.txt") | |||
| let p2 = #fileLiteral(resourceName: "what.txt") // expected-error{{could not infer type of file reference literal}} expected-note{{import Foundation to use 'URL' as the default file reference literal type}} | |||
|
|
|||
| let text = #fileLiteral(resourceName: "TextFile.txt").relativeString! // expected-error{{type of expression is ambiguous without more context}} | |||
There was a problem hiding this comment.
Is this actually ambiguous, or is this because there is no relativeString member in any of the things that #fileLiteral could be and we're emitting a misleading diagnostic?
There was a problem hiding this comment.
It's because there's no relativeString and we're emitting a misleading diagnostic. Actually, I think the default #fileLiteral type isn't even around; we get a different diagnostic about to having a relativeString member with the real SDK
MaxDesiatov
pushed a commit
that referenced
this pull request
Sep 7, 2023
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://problem/26586984.
(cherry picked from commit e5b9ad7)