Skip to content

Sema: Skip members of unavailable extensions for -require-explicit-availability #58426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tshortli
Copy link
Contributor

When diagnosing required explicit availability, skip members of extensions that have been declared explicitly unavailable. The existing logic only checked for an unavailable attr in the direct attributes of the decl.

Resolves rdar://85429703

… extensions that have been declared explicitly unavailable. The existing logic only checked for an unavailable attr in the direct attributes of the decl.

Resolves rdar://85429703
@tshortli tshortli requested a review from xymus April 26, 2022 22:42
@tshortli
Copy link
Contributor Author

@swift-ci please smoke test

Copy link
Contributor

@xymus xymus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks.

@tshortli tshortli merged commit a66257e into swiftlang:main Apr 27, 2022
@tshortli tshortli deleted the require-explicit-availability-unavailable-extension branch May 8, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants