Skip to content

[5.7][CodeCompletion] Maintain LeaveClosureBodiesUnchecked when checking pattern binding #58691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented May 5, 2022

Cherry-pick #58662 to release/5.7


…attern binding

Before, we were dropping `LeaveClosureBodiesUnchecked` when checking a pattern binding request which caused missing completions inside variables initialized by closures.

rdar://92603748 [swiftlang#58610]
@ahoppen ahoppen added the r5.7 label May 5, 2022
@ahoppen ahoppen requested a review from a team as a code owner May 5, 2022 19:42
@ahoppen
Copy link
Member Author

ahoppen commented May 5, 2022

@swift-ci Please test

@ahoppen ahoppen merged commit a10318d into swiftlang:release/5.7 May 6, 2022
@ahoppen ahoppen deleted the pr-5.7/closure-in-pattern-binding branch May 6, 2022 17:30
@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.7 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants