Skip to content

Actually slice things in _StringGutsSlice #58948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2022

Conversation

Catfish-Man
Copy link
Contributor

@Catfish-Man Catfish-Man commented May 17, 2022

rdar://87371813
#59388
#59066

@Catfish-Man Catfish-Man requested review from lorentey and Azoy May 17, 2022 20:07
@Catfish-Man
Copy link
Contributor Author

Next up: writing some tests and making sure this works

Copy link
Contributor

@Azoy Azoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good to me! 😅

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test and merge

@Catfish-Man
Copy link
Contributor Author

@swift-ci please benchmark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants