[SwiftCompilerModules] Link lib_InternalSwiftSyntaxParser to libswift #59209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
rintaro
force-pushed
the
syntaxparser-libswift
branch
from
de444a4 to
befb55d
Compare
|
@swift-ci Please smoke test |
rintaro
force-pushed
the
syntaxparser-libswift
branch
from
befb55d to
ce70510
Compare
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
To use _RegexParser from SwiftSyntax. * Create 'libswiftCompilerModules_SwiftSyntax.a' which is a subset of 'libswiftCompilerModules.a' * Link 'lib_InternalSwiftSyntaxParser' to 'libswiftCompilerModules_SwiftSyntax.a' * Factor out swift runtime linking logic in CMake so that dynamic libraries can link to Swift runtime, in addition to executables * Link 'lib_InternalSwiftSyntaxParser' to swift runtime
Now that libSwiftSyntaxParser links to libswift. We don't need this anymore.
rintaro
force-pushed
the
syntaxparser-libswift
branch
from
c7f0819 to
8826ef6
Compare
|
@swift-ci Please test |
rintaro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use _RegexParser from SwiftSyntax.
libswiftCompilerModules_SwiftSyntax.awhich is a subset oflibswiftCompilerModules.alib_InternalSwiftSyntaxParsertolibswiftCompilerModules_SwiftSyntax.alib_InternalSwiftSyntaxParserto swift runtime