Fixup Extended Existential Metatype Casts #59507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix here is two-fold: 1) Teach SILGen that it cannot use the scalar casting paths for extended existentials 2) Teach the runtime casting entrypoint to unwrap as much metatype structure as possible before arriving at a 'Self' type bound for the requirement checking paths. The code here mirrors the destructuring check we're doing in remote mirrors. rdar://95166916
Return a NULL demangle tree instead of crashing. When an unconditional runtime cast fails, it's going to crash anyways, but this way it prints a better description (though not great) than the unreachable's message here.
|
@swift-ci smoke test |
|
@swift-ci smoke test macOS |
rjmccall
requested changes
Jun 16, 2022
Ensure the last node after all of the destructuring really is a dependent generic param type. If it isn't, something has gone horribly wrong.
|
@swift-ci smoke test |
|
@swift-ci smoke test macOS |
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix here is two-fold:
before arriving at a 'Self' type bound for the requirement checking paths.
The code here mirrors the destructuring check we're doing in remote mirrors.
rdar://95166916