🍒[5.7][Concurrency] Settable prop reqs cannot be witnessed by actors #59585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
changed the title
ktoso
added
concurrency
|
@swift-ci please test |
DougGregor
reviewed
Jun 22, 2022
|
I'm going to mark this as draft, perhaps there is a better way to prevent this in isolation checking for conformances. |
|
Superseded by #59655 |
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This fixes a hole in actor isolation. Accessing a get/set property in a
Actorconstrained protocol was allowed but this is illegal and would have produced a race. The fix is to correctly prevent such conformances -- since they cannot exist due to lack of async setters.Risk: Low
Importance: Existing code using this was bypassing actor isolation and could be crashing with race conditions
Review by: @DougGregor @kavon
Testing: PR testing
Original PR: #59580
Radar: rdar://95509917
Issue: #59573