[5.7][ConstraintSystem] Allow injecting callAsFunction after defaulted a…
#59732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rguments
- Adjust argument matching to be less aggressive while matching misplaced trailing closures
against defaulted parameters that do not accept trailing closures.
For example:
```swift
func test(a: Int? = 42, b: String? = nil) {}
test {
...
}
```
Trailing closure in this case should be marked as "extraneous" instead of matched
against parameter `a:`.
- If trailing closure is extraneous in a call to `.init` on callable type, let's not attempt to
to fix it and allow solver to inject `.callAsFunction` first.
Resolves: rdar://problem/94959816
(cherry picked from commit ea4ac2c)
(cherry picked from commit 2750e69)
xedin
changed the title
callAsFunction after defaulted a…callAsFunction after defaulted a…
|
@swift-ci please test |
hborla
approved these changes
Jun 27, 2022
|
@swift-ci please test macOS platform |
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rguments
Cherry-pick of #59432
Adjust argument matching to be less aggressive while matching misplaced trailing closures
against defaulted parameters that do not accept trailing closures.
For example:
Trailing closure in this case should be marked as "extraneous" instead of matched
against parameter
a:.If trailing closure is extraneous in a call to
.initon callable type, let's not attempt toto fix it and allow solver to inject
.callAsFunctionfirst.Resolves: rdar://problem/94959816
(cherry picked from commit ea4ac2c)
(cherry picked from commit 2750e69)