Skip to content

Add an option for an explicit interface build without an additional Compile SubInstance #60556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 16, 2022

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Aug 15, 2022

  • Refactor ModuleInterfaceBuilder to separate CompilerInstance setup logic from compilation logic (moved to ExplicitModuleInterfaceBuilder).
  • Factor out reading flags/version from an interface from setting up a Compiler subinstance.
  • Invoke Explicit Interface Build when -explicit-interface-module-build is specified on a -compile-module-from-interface frontend action, using the CompilerInstance instantiated directly from the command-line in order to build the module.

@artemcm
Copy link
Contributor Author

artemcm commented Aug 15, 2022

@swift-ci please test

@artemcm artemcm marked this pull request as ready for review August 15, 2022 18:00
@artemcm artemcm requested review from nkcsgexi, tshortli and xymus August 15, 2022 18:00
@artemcm artemcm force-pushed the ExplicitInterfaceBuild branch from 6f14c39 to c4167b7 Compare August 15, 2022 18:17
Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@artemcm artemcm force-pushed the ExplicitInterfaceBuild branch from c4167b7 to 4d13be2 Compare August 15, 2022 23:11
@artemcm
Copy link
Contributor Author

artemcm commented Aug 15, 2022

@swift-ci please test

@artemcm artemcm force-pushed the ExplicitInterfaceBuild branch 2 times, most recently from d4222d5 to 0986e50 Compare August 16, 2022 01:19
@artemcm
Copy link
Contributor Author

artemcm commented Aug 16, 2022

@swift-ci please test

…logic from compilation logic (moved to ExplicitModuleInterfaceBuilder).
…d' is specified on a '-compile-module-from-interface' frontend action, using the CompilerInstance instantiated directly from the command-line in order to build the module.
@artemcm artemcm force-pushed the ExplicitInterfaceBuild branch from 0986e50 to aee4579 Compare August 16, 2022 15:37
@artemcm
Copy link
Contributor Author

artemcm commented Aug 16, 2022

@swift-ci test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants