[CSApply] Attempt value-to-opaque-result abstraction only after canon… #60568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please clean test |
…icalization `ExprRewriter::coerceToType` should canonicalize contextual type before attempting to use it for value abstraction, because sugared type could have typealias references that hide their underlying opaque result types. Resolves: rdar://98577451
|
@swift-ci please test |
slavapestov
reviewed
Aug 16, 2022
| @@ -0,0 +1,21 @@ | |||
| // RUN: %target-typecheck-verify-swift -target %target-cpu-apple-macosx10.15 | |||
There was a problem hiding this comment.
You can just pass -disable-availability-checking instead and remove the REQUIRES: lines.
There was a problem hiding this comment.
I wasn't sure whether it's supposed to work on Linux/Windows or not...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…icalization
ExprRewriter::coerceToTypeshould canonicalize contextual type beforeattempting to use it for value abstraction, because sugared type could
have typealias references that hide their underlying opaque result types.
Resolves: rdar://98577451