[Explicit Modules] On an explicit interface build, early exit if expected output is up-to-date. #60585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 'ModuleInterfaceLoaderImpl' logic, to be used by other clients
|
@swift-ci test |
…expected output is up-to-date.
artemcm
force-pushed
the
SeparateUpToDateCheck
branch
from
16844eb to
256c0ff
Compare
|
@swift-ci test |
nkcsgexi
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two changes:
ModuleInterfaceLoaderImplthat check if a given binary Swift module is up-to-date by verifying all of its serialized files dependency timestamps into a separate implementation helper class -UpToDateModuleChecker, so that it can be used by other clients.UpToDateModuleCheckerin the explicit interface build code-path to early exit when the.swiftinterface->.swiftmodulebuild action is not needed because the expected output is already up-to-date.-Rskip-explicit-interface-buildis specified and the above early exit is taken.