Generalize ActorIsolation to capture arbitrary isolated parameters #60799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A function can be actor instance-isolated to one of its parameters. Make sure that this is reflected in ActorIsolation, so such a function doesn't get a different actor isolation.
The generalized ActorIsolation is enough to represent everything that ImplicitActorHopTarget can do, and we were mapping between the two way too often, so collapse them.
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize the central
ActorIsolationtype to describe isolation to an isolated parameter that is notself. This allows us to properly express the isolation of such declarations, replacing some bespoke hacks with the same central model used forself-isolated and global-actor-isolated declarations. It also subsumesImplicitActorHopTarget, so remove that type and replace all uses of it withActorIsolation.