[Sema] TypeWrappers: Don't try to manage compiler synthesized properties #60864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properties like `unownedExecutor` that are implicitly injected into a type should not be managed by a type wrapper.
hborla
approved these changes
Aug 30, 2022
|
@swift-ci please test |
xedin
force-pushed
the
type-wrappers-on-actors
branch
from
b430e86 to
009943e
Compare
|
@swift-ci please test |
xedin
force-pushed
the
type-wrappers-on-actors
branch
from
009943e to
1dc9b81
Compare
xedin
force-pushed
the
type-wrappers-on-actors
branch
from
1dc9b81 to
325b54d
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properties like
unownedExecutorthat are implicitly injected into a typeshould not be managed by a type wrapper.
Expand tests to cover type wrapper/actor interaction.