[build] Remove unused GLIBC_INCLUDE_PATH macro
#60956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @buttaface @3405691582 |
|
@swift-ci please smoke test |
compnerd
approved these changes
Sep 5, 2022
finagolfin
approved these changes
Sep 5, 2022
There was a problem hiding this comment.
Glad to see this gone, but you missed one that @3405691582 added recently.
Pinging @kateinoigakukun to sign off on WASI change.
This macro was previously substituted when generating `glibc.modulemap` file during the compiler build. Now Swift detects the location of Glibc dynamically and injects `glibc.modulemap` into it using LLVM VFS. The last usage of `GLIBC_INCLUDE_PATH` was removed in `78c0540b`.
This also removes `SWIFT_SDK_${sdk}_ARCH_${arch}_LIBC_INCLUDE_DIRECTORY` which doesn't have any usages left.
egorzhdan
force-pushed
the
egorzhdan/no-libc-path
branch
from
752ae7b to
ba31ca4
Compare
Thanks, forgot to update my checkout :) |
|
@swift-ci please smoke test |
kateinoigakukun
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This macro was previously substituted when generating
glibc.modulemapfile during the compiler build. Now Swift detects the location of Glibc dynamically and injectsglibc.modulemapinto it using LLVM VFS. The last usage ofGLIBC_INCLUDE_PATHwas removed in 78c0540.This also removes
SWIFT_SDK_${sdk}_ARCH_${arch}_LIBC_INCLUDE_DIRECTORYwhich doesn't have any usages left.