Skip to content

[DI] Add a way to find value of self in initializer context #61206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Sep 20, 2022

This is staging for type wrappers that need to inject self.$storage = ... call to user-defined initializers, to be able to do that logic needs to be able to find self that is being constructed.

@xedin xedin requested a review from kavon September 20, 2022 17:48
Copy link
Member

@kavon kavon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after a simple refactoring I think this is good.

This is staging for type wrappers that need to inject
`self.$storage = ...` call to user-defined initializers,
to be able to do that logic needs to be able to find
`self` that is being constructed.
@xedin xedin force-pushed the DI-self-value-finder branch from d74abf5 to f66f9dc Compare September 20, 2022 21:36
@xedin
Copy link
Contributor Author

xedin commented Sep 20, 2022

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Sep 21, 2022

@swift-ci please test Linux platform

@xedin
Copy link
Contributor Author

xedin commented Sep 21, 2022

@swift-ci please test Windows platform

@xedin xedin merged commit 28ab0bd into swiftlang:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants