Skip to content

update-checkout: Do not update repository if not listed in the given branch-scheme #61275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2022

Conversation

AnthonyLatsis
Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis commented Sep 23, 2022

Consider two branch-schemes, where the second is a subset of the first. Suppose repositories have been cloned using the first branch scheme. Previously, a successive update using the second branch-scheme would cause update-checkout to fail in an attempt to query the branch-scheme about the target branch for a repository it does not map, even though the update, given no further errors, can be considered successful.

@AnthonyLatsis AnthonyLatsis force-pushed the scheme-oriented-checkouts branch 2 times, most recently from 8eb73c6 to 6ffcbad Compare September 23, 2022 22:26
…branch-scheme

Consider two branch-schemes, where the second is a subset of the first.
Suppose repositories have been cloned using the first branch scheme. Previously,
a successive update using the second branch-scheme would cause update-checkout
to fail in an attempt to query the branch-scheme about the target branch for a
repository it does not map, even though the update, given no further errors, can
be considered successful.
@AnthonyLatsis AnthonyLatsis force-pushed the scheme-oriented-checkouts branch from 6ffcbad to abd17b6 Compare September 24, 2022 03:07
@AnthonyLatsis AnthonyLatsis added contributor experience update-checkout Area → utils: the `update-checkout` script labels Sep 28, 2022
@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please Python lint

@AnthonyLatsis
Copy link
Collaborator Author

@gottesmm ping

@AnthonyLatsis
Copy link
Collaborator Author

@shahmishal ping

Copy link
Contributor

@gottesmm gottesmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding a test!

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

@AnthonyLatsis
Copy link
Collaborator Author

Thanks for reviewing!

@AnthonyLatsis AnthonyLatsis merged commit 47d76d2 into swiftlang:main Oct 15, 2022
@AnthonyLatsis AnthonyLatsis deleted the scheme-oriented-checkouts branch October 15, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor experience update-checkout Area → utils: the `update-checkout` script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants