Skip to content

[DebugInfo] Respect debug-prefix-map when emitting path to PCM in Skeleton CUs #61583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

bulbazord
Copy link
Contributor

The splitDebugFilename field doesn't respect the debug-prefix-map, making it difficult to produce relocatable debug info.

@bulbazord
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that that makes sense if you know what you are doing. Clang module caches aren't supposed to be portable between machines, but we are only interested in the debug info here so it will work. Thanks!

@bulbazord
Copy link
Contributor Author

@swift-ci please test

@bulbazord bulbazord merged commit 9aa4c93 into swiftlang:main Oct 18, 2022
@bulbazord bulbazord deleted the prefix-remapping branch October 18, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants