Skip to content

[Diagnostics] Improve diagnostics involving implicitly unwrapped optional functions #6187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2016

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Dec 10, 2016

In FailureDiagnosis::visitApplyExpr and CalleeCandidateInfo try to look
through ImplicitlyUnwrappedOptional function type, which improves diagnostics
for calls with invalid arguments.

Resolves SR-3248.

…onal functions

In FailureDiagnosis::visitApplyExpr and CalleeCandidateInfo try to look
through ImplicitlyUnwrappedOptional function type, which improves diagnostics
for calls with invalid arguments.

Resolves: SR-3248.
@xedin
Copy link
Contributor Author

xedin commented Dec 10, 2016

/cc @rudkx @DougGregor @jrose-apple

@rudkx rudkx self-assigned this Dec 11, 2016
Copy link
Contributor

@rudkx rudkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rudkx
Copy link
Contributor

rudkx commented Dec 11, 2016

@swift-ci Please smoke test and merge

@swift-ci swift-ci merged commit fe4bac5 into swiftlang:master Dec 11, 2016
Copy link
Contributor

@NachoSoto NachoSoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants