[ModuleInterface] Avoid ambiguities in swiftinterfaces by writing aliases for module names #61941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ambiguities are introduced in generated swiftinterfaces when a type shares a name with a module (i.e. XCTest). This workaround uses the module-alias feature to avoid these ambiguities. Writing module references with a distinguishable prefix should allow normal type-checking to avoid the usual ambiguities. We should still aim for a proper fully-qualified named syntax, but this may help in the mean time. rdar://101969500
|
@swift-ci Please smoke test |
|
I'll have to do more work on this feature so I'll keep an eye on review comments and will apply them in the next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ambiguities are introduced in generated swiftinterfaces when a type shares a name with a module. This PR introduces a workaround (behind a flag) that uses the module-alias feature to avoid these ambiguities. Writing module references with a distinguishable prefix should allow normal type-checking to avoid the usual ambiguities.
We should still aim for a proper fully-qualified name syntax, but this may help in the mean time. I'm considering enabling this by default in the future, but I'll have to write more tests before it's reliable enough in all cases to do so.
rdar://101969500