[ModuleInterface] Support loading an aliased module with an underlying module #62044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…module Importing a module using an alias (set with -module-alias) fails if the imported module has an underlying clang module. rdar://102217790
Set the env var SWIFT_ALIAS_MODULE_NAMES_IN_INTERFACES to turn on generating swiftinterfaces with the AliasModuleNames workaround by default.
|
@swift-ci Please smoke test |
tshortli
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure we can import a module given an alias (using
-module-alias) in the case where it has an underlying clang module. Prior to this fix it was wrongfully reported as a cyclic dependency.Also introduce an env var to test this feature before turning it on by default.
This is a fix for the workaround introduced in #61941.
rdar://102217790