[SILInliner] Borrow guaranteed yields. #62286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When inlining a begin_apply, if one of the values is yielded by guaranteed convention, if the yielded value is itself owned, borrow it during inlining. Doing so is necessary because users of the yielded value are expecting a value with guaranteed ownership. For example, it's valid to store_borrow such a value but not an owned value.
|
@swift-ci please test |
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inlining a begin_apply, if one of the values is yielded by guaranteed convention, if the yielded value is itself owned, borrow it during inlining.
Doing so is necessary because users of the yielded value are expecting a value with guaranteed ownership. For example, it's valid to
store_borrowsuch a value but not an owned value.